Commit Graph

107 Commits

  • Refactor configuration access to use latest_arc() instead of latest_ref()
    - Updated multiple instances in the codebase to replace calls to latest_ref() with latest_arc() for improved performance and memory management.
    - This change affects various modules including validate, enhance, feat (backup, clash, config, profile, proxy, window), utils (draft, i18n, init, network, resolve, server).
    - Ensured that all references to configuration data are now using the new arc-based approach to enhance concurrency and reduce cloning overhead.
    
    refactor: update imports to explicitly include ClashInfo and Config in command files
  • Refactor logging to use a centralized logging utility across the application (#5277)
    - Replaced direct log calls with a new logging macro that includes a logging type for better categorization.
    - Updated logging in various modules including `merge.rs`, `mod.rs`, `tun.rs`, `clash.rs`, `profile.rs`, `proxy.rs`, `window.rs`, `lightweight.rs`, `guard.rs`, `autostart.rs`, `dirs.rs`, `dns.rs`, `scheme.rs`, `server.rs`, and `window_manager.rs`.
    - Introduced logging types such as `Core`, `Network`, `ProxyMode`, `Window`, `Lightweight`, `Service`, and `File` to enhance log clarity and filtering.
  • refactor: reduce clone operation (#5268)
    * refactor: optimize item handling and improve profile management
    
    * refactor: update IVerge references to use references instead of owned values
    
    * refactor: update patch_verge to use data_ref for improved data handling
    
    * refactor: move handle_copy function to improve resource initialization logic
    
    * refactor: update profile handling to use references for improved memory efficiency
    
    * refactor: simplify get_item method and update profile item retrieval to use string slices
    
    * refactor: update profile validation and patching to use references for improved performance
    
    * refactor: update profile functions to use references for improved performance and memory efficiency
    
    * refactor: update profile patching functions to use references for improved memory efficiency
    
    * refactor: simplify merge function in PrfOption to enhance readability
    
    * refactor: update change_core function to accept a reference for improved memory efficiency
    
    * refactor: update PrfItem and profile functions to use references for improved memory efficiency
    
    * refactor: update resolve_scheme function to accept a reference for improved memory efficiency
    
    * refactor: update resolve_scheme function to accept a string slice for improved flexibility
    
    * refactor: simplify update_profile parameters and logic
  • refactor: convert file operations to async using tokio fs (#5267)
    * refactor: convert file operations to async using tokio fs
    
    * refactor: integrate AsyncHandler for file operations in backup processes
  • refactor(tray): comment out enable_tray_icon references for future removal #5161
    Since network speed display in Tray on menu has been removed
  • feat(clippy): cognitive-complexity rule (#5215)
    * feat(config): enhance configuration initialization and validation process
    
    * refactor(profile): streamline profile update logic and enhance error handling
    
    * refactor(config): simplify profile item checks and streamline update flag processing
    
    * refactor(disney_plus): add cognitive complexity allowance for check_disney_plus function
    
    * refactor(enhance): restructure configuration and profile item handling for improved clarity and maintainability
    
    * refactor(tray): add cognitive complexity allowance for create_tray_menu function
    
    * refactor(config): add cognitive complexity allowance for patch_config function
    
    * refactor(profiles): simplify item removal logic by introducing take_item_file_by_uid helper function
    
    * refactor(profile): add new validation logic for profile configuration syntax
    
    * refactor(profiles): improve formatting and readability of take_item_file_by_uid function
    
    * refactor(cargo): change cognitive complexity level from warn to deny
    
    * refactor(cargo): ensure cognitive complexity is denied in Cargo.toml
    
    * refactor(i18n): clean up imports and improve code readability
    refactor(proxy): simplify system proxy toggle logic
    refactor(service): remove unnecessary `as_str()` conversion in error handling
    refactor(tray): modularize tray menu creation for better maintainability
    
    * refactor(tray): update menu item text handling to use references for improved performance
  • feat: add signal handling for graceful shutdown on Windows and Unix (#5023)
    * feat: add signal handling for graceful shutdown on Windows and Unix
    
    Co-authored-by: oomeow <oomeow@outlook.com>
    
    * chore: update Cargo.lock
    
    * fix(windows): restore shutdown hook build by enabling missing Win32 APIs and removing stray tracing call
    
    Includes the required windows-sys feature expansions and replaces a leftover tracing reference so the Windows shutdown hook builds successfully.
    
    * fix: add deprecation warnings for encrypt_data and decrypt_data functions
    
    ---------
    
    Co-authored-by: oomeow <oomeow@outlook.com>
    Co-authored-by: Slinetrac <realakayuki@gmail.com>
  • perf: utilize smartstring for string handling (#5149)
    * perf: utilize smartstring for string handling
    
    - Updated various modules to replace standard String with smartstring::alias::String for improved performance and memory efficiency.
    - Adjusted string manipulations and conversions throughout the codebase to ensure compatibility with the new smartstring type.
    - Enhanced readability and maintainability by using `.into()` for conversions where applicable.
    - Ensured that all instances of string handling in configuration, logging, and network management leverage the benefits of smartstring.
    
    * fix: replace wrap_err with stringify_err for better error handling in UWP tool invocation
    
    * refactor: update import path for StringifyErr and adjust string handling in sysopt
    
    * fix: correct import path for CmdResult in UWP module
    
    * fix: update argument type for execute_sysproxy_command to use std::string::String
    
    * fix: add missing CmdResult import in UWP platform module
    
    * fix: improve string handling and error messaging across multiple files
    
    * style: format code for improved readability and consistency across multiple files
    
    * fix: remove unused file
  • refactor: convert synchronous file operations to asynchronous for improved performance (#5059)
    * refactor: convert synchronous file operations to asynchronous for improved performance
    
    * fix: update copy_icon_file to use asynchronous directory creation
    
    * refactor: remove unnecessary variable assignments in shortcut management functions
  • feat: local backup (#5054)
    * feat: local backup
    
    * refactor(backup): make local backup helpers synchronous and clean up redundant checks
    
    - Converted local backup helpers to synchronous functions to remove unused async warnings and align command signatures.
    - Updated list/delete/export commands to call the sync feature functions directly without awaits while preserving behavior.
    - Simplified destination directory creation to always ensure parent folders exist without redundant checks, satisfying Clippy.
  • fix(shutdown): mark shutdown as exiting to stop background tasks (#5024)
    * fix(shutdown): mark shutdown as exiting to stop background tasks
    
    - lib.rs:570 → Flag app as exiting on ExitRequested, notify proxy guard, start cleanup immediately, with fallback in Exit event
    - tray/mod.rs:190 → Add unified exit checks around tray init/updates to prevent UI recreation during shutdown
    - event_driven_proxy.rs:252 → Ensure proxy guard skips all restore/re-enable work (including sysproxy.exe calls) once exit flag is set
    
    * fix(shutdown): refine exit handling and proxy guard notifications
    
    * fix(shutdown): add guard to run shutdown routine only once per lifecycle
  • Refactor logging macros to remove print control parameter
    - Updated logging macros to eliminate the boolean parameter for print control, simplifying the logging calls throughout the codebase.
    - Adjusted all logging calls in various modules (lib.rs, lightweight.rs, help.rs, init.rs, logging.rs, resolve/mod.rs, resolve/scheme.rs, resolve/ui.rs, resolve/window.rs, server.rs, singleton.rs, window_manager.rs) to reflect the new macro structure.
    - Ensured consistent logging behavior across the application by standardizing the logging format.
  • fix: restart app failed (#4974)
    * fix: failed to restart app
    
    * chore: cleanup
    
    * chore: cargo fmt
    
    * chore: use AsyncHandler
    
    * chore: clippy
    
    * chore: update
  • refactor: invock mihomo api by use tauri-plugin-mihomo (#4926)
    * feat: add tauri-plugin-mihomo
    
    * refactor: invock mihomo api by use tauri-plugin-mihomo
    
    * chore: todo
    
    * chore: update
    
    * chore: update
    
    * chore: update
    
    * chore: update
    
    * fix: incorrect delay status and update pretty config
    
    * chore: update
    
    * chore: remove cache
    
    * chore: update
    
    * chore: update
    
    * fix: app freezed when change group proxy
    
    * chore: update
    
    * chore: update
    
    * chore: add rustfmt.toml to tauri-plugin-mihomo
    
    * chore: happy clippy
    
    * refactor: connect mihomo websocket
    
    * chore: update
    
    * chore: update
    
    * fix: parse bigint to number
    
    * chore: update
    
    * Revert "fix: parse bigint to number"
    
    This reverts commit 74c006522e.
    
    * chore: use number instead of bigint
    
    * chore: cleanup
    
    * fix: rule data not refresh when switch profile
    
    * chore: update
    
    * chore: cleanup
    
    * chore: update
    
    * fix: traffic graph data display
    
    * feat: add ipc connection pool
    
    * chore: update
    
    * chore: clippy
    
    * fix: incorrect delay status
    
    * fix: typo
    
    * fix: empty proxies tray menu
    
    * chore: clippy
    
    * chore: import tauri-plugin-mihomo by using git repo
    
    * chore: cleanup
    
    * fix: mihomo api
    
    * fix: incorrect delay status
    
    * chore: update tauri-plugin-mihomo dep
    
    chore: update
  • fix(tray): resolve "Restart App" failure on Windows (#4960)
    * fix(tray): resolve "Restart App" failure on Windows
    
    * style: rm useless comment
  • fix: implement proper error handling for "Restart App" failures (#4951)
    * fix: implement proper error handling for "Restart App" failures
    
    * fix: make clippy happy
  • fix(webdav/app): reset client on errors and improve app restart (#4941)
    * fix(webdav/app): reset client on errors and improve app restart
    
    * refactor: rm unused function
  • edition 2024 (#4702)
    * feat: update Cargo.toml for 2024 edition and optimize release profiles
    
    * feat: refactor environment variable settings for Linux and improve code organization
    
    * Refactor conditional statements to use `&&` for improved readability
    
    - Updated multiple files to combine nested `if let` statements using `&&` for better clarity and conciseness.
    - This change enhances the readability of the code by reducing indentation levels and making the conditions more straightforward.
    - Affected files include: media_unlock_checker.rs, profile.rs, clash.rs, profiles.rs, async_proxy_query.rs, core.rs, handle.rs, hotkey.rs, service.rs, timer.rs, tray/mod.rs, merge.rs, seq.rs, config.rs, proxy.rs, window.rs, general.rs, dirs.rs, i18n.rs, init.rs, network.rs, and window.rs in the resolve module.
    
    * refactor: streamline conditional checks using `&&` for improved readability
    
    * fix: update release profile settings for panic behavior and optimization
    
    * fix: adjust optimization level in Cargo.toml and reorder imports in lightweight.rs
  • fix: resolve from lightweight cause crash (#4682)
    * refactor: streamline lightweight mode handling and improve window management
    
    * refactor: replace mutex-based window creation lock with atomic operations for improved performance
    
    * refactor: remove startup completed event handling and simplify initialization logic
    
    * refactor: remove conditional compilation for emit_update_event function
    
    * refactor: simplify return statements and clean up commented code in lightweight and window manager modules
    
    * refactor: streamline lightweight mode handling by consolidating window management calls
    
    * refactor: prevent unnecessary window toggle when exiting lightweight mode
    
    * refactor: reorder imports for consistency in lightweight module
    
    * refactor: move macOS specific logging_error import for clarity
  • feat: update Cargo.toml for 2024 edition and optimize release profiles (#4681)
    * feat: update Cargo.toml for 2024 edition and optimize release profiles
    
    * feat: refactor environment variable settings for Linux and improve code organization
    
    * Refactor conditional statements to use `&&` for improved readability
    
    - Updated multiple files to combine nested `if let` statements using `&&` for better clarity and conciseness.
    - This change enhances the readability of the code by reducing indentation levels and making the conditions more straightforward.
    - Affected files include: media_unlock_checker.rs, profile.rs, clash.rs, profiles.rs, async_proxy_query.rs, core.rs, handle.rs, hotkey.rs, service.rs, timer.rs, tray/mod.rs, merge.rs, seq.rs, config.rs, proxy.rs, window.rs, general.rs, dirs.rs, i18n.rs, init.rs, network.rs, and window.rs in the resolve module.
    
    * refactor: streamline conditional checks using `&&` for improved readability
  • refactor: migrate from serde_yaml to serde_yaml_ng for improved YAML handling (#4568)
    * refactor: migrate from serde_yaml to serde_yaml_ng for improved YAML handling
    
    * refactor: format code for better readability in DNS configuration
  • refactor: enhance async initialization and streamline setup process (#4560)
    * feat: Implement DNS management for macOS
    
    - Added `set_public_dns` and `restore_public_dns` functions in `dns.rs` to manage system DNS settings.
    - Introduced `resolve` module to encapsulate DNS and scheme resolution functionalities.
    - Implemented `resolve_scheme` function in `scheme.rs` to handle deep links and profile imports.
    - Created UI readiness management in `ui.rs` to track and update UI loading states.
    - Developed window management logic in `window.rs` to handle window creation and visibility.
    - Added initial loading overlay script in `window_script.rs` for better user experience during startup.
    - Updated server handling in `server.rs` to integrate new resolve functionalities.
    - Refactored window creation calls in `window_manager.rs` to use the new window management logic.
    
    * refactor: streamline asynchronous handling in config and resolve setup
    
    * Revert "refactor: streamline asynchronous handling in config and resolve setup"
    
    This reverts commit 23d7dc86d5.
    
    * fix: optimize asynchronous memory handling
    
    * fix: enhance task logging by adding size check for special cases
    
    * refactor: enhance async initialization and streamline setup process
    
    * refactor: optimize async setup by consolidating initialization tasks
    
    * chore: update changelog for Mihomo(Meta) kernel upgrade to v1.19.13
    
    * fix: improve startup phase initialization performance
    
    * refactor: optimize file read/write performance to reduce application wait time
    
    * refactor: simplify app instance exit logic and adjust system proxy guard initialization
    
    * refactor: change resolve_setup_async to synchronous execution for improved performance
    
    * refactor: update resolve_setup_async to accept AppHandle for improved initialization flow
    
    * refactor: remove unnecessary initialization of portable flag in run function
    
    * refactor: consolidate async initialization tasks into a single blocking call for improved execution flow
    
    * refactor: optimize resolve_setup_async by restructuring async tasks for improved concurrency
    
    * refactor: streamline resolve_setup_async and embed_server for improved async handling
    
    * refactor: separate synchronous and asynchronous setup functions for improved clarity
    
    * refactor: simplify async notification handling and remove redundant network manager initialization
    
    * refactor: enhance async handling in proxy request cache and window creation logic
    
    * refactor: improve code formatting and readability in ProxyRequestCache
    
    * refactor: adjust singleton check timeout and optimize trace size conditions
    
    * refactor: update TRACE_SPECIAL_SIZE to include additional size condition
    
    * refactor: update kode-bridge dependency to version 0.2.1-rc2
    
    * refactor: replace RwLock with AtomicBool for UI readiness and implement event-driven monitoring
    
    * refactor: convert async functions to synchronous for window management
    
    * Update src-tauri/src/utils/resolve/window.rs
    
    * fix: handle missing app_handle in create_window function
    
    * Update src-tauri/src/module/lightweight.rs
  • fix(subscription): resolve issues causing import failures in some cases #4534, #4436, #4552, #4519, #4517, #4503, #4336, #4301 (#4553)
    * fix(subscription): resolve issues causing import failures in some cases #4534, #4436, #4552, #4519, #4517, #4503, #4336, #4301
    
    * fix(profile): update profile creation to include file data handling
    
    * fix(app): improve singleton instance exit handling
    
    * fix: remove unsued handle method
  • refactor(async): migrate from sync-blocking async execution to true async with unified AsyncHandler::spawn (#4502)
    * feat: replace all tokio::spawn with unified AsyncHandler::spawn
    
    - 🚀 Core Improvements:
      * Replace all tokio::spawn calls with AsyncHandler::spawn for unified Tauri async task management
      * Prioritize converting sync functions to async functions to reduce spawn usage
      * Use .await directly in async contexts instead of spawn
    
    - 🔧 Major Changes:
      * core/hotkey.rs: Use AsyncHandler::spawn for hotkey callback functions
      * module/lightweight.rs: Async lightweight mode switching
      * feat/window.rs: Convert window operation functions to async, use .await internally
      * feat/proxy.rs, feat/clash.rs: Async proxy and mode switching functions
      * lib.rs: Window focus handling with AsyncHandler::spawn
      * core/tray/mod.rs: Complete async tray event handling
    
    -  Technical Advantages:
      * Unified task tracking and debugging capabilities (via tokio-trace feature)
      * Better error handling and task management
      * Consistency with Tauri runtime
      * Reduced async boundaries for better performance
    
    - 🧪 Verification:
      * Compilation successful with 0 errors, 0 warnings
      * Maintains complete original functionality
      * Optimized async execution flow
    
    * feat: complete tokio fs migration and replace tokio::spawn with AsyncHandler
    
    🚀 Major achievements:
    - Migrate 8 core modules from std::fs to tokio::fs
    - Create 6 Send-safe wrapper functions using spawn_blocking pattern
    - Replace all tokio::spawn calls with AsyncHandler::spawn for unified async task management
    - Solve all 19 Send trait compilation errors through innovative spawn_blocking architecture
    
    🔧 Core changes:
    - config/profiles.rs: Add profiles_*_safe functions to handle Send trait constraints
    - cmd/profile.rs: Update all Tauri commands to use Send-safe operations
    - config/prfitem.rs: Replace append_item calls with profiles_append_item_safe
    - utils/help.rs: Convert YAML operations to async (read_yaml, save_yaml)
    - Multiple modules: Replace tokio::task::spawn_blocking with AsyncHandler::spawn_blocking
    
     Technical innovations:
    - spawn_blocking wrapper pattern resolves parking_lot RwLock Send trait conflicts
    - Maintain parking_lot performance while achieving Tauri async command compatibility
    - Preserve backwards compatibility with gradual migration strategy
    
    🎯 Results:
    - Zero compilation errors
    - Zero warnings
    - All async file operations working correctly
    - Complete Send trait compliance for Tauri commands
    
    * feat: refactor app handle and command functions to use async/await for improved performance
    
    * feat: update async handling in profiles and logging functions for improved error handling and performance
    
    * fix: update TRACE_MINI_SIZE constant to improve task logging threshold
    
    * fix(windows): convert service management functions to async for improved performance
    
    * fix: convert service management functions to async for improved responsiveness
    
    * fix(ubuntu): convert install and reinstall service functions to async for improved performance
    
    * fix(linux): convert uninstall_service function to async for improved performance
    
    * fix: convert uninstall_service call to async for improved performance
    
    * fix: convert file and directory creation calls to async for improved performance
    
    * fix: convert hotkey functions to async for improved responsiveness
    
    * chore: update UPDATELOG.md for v2.4.1 with major improvements and performance optimizations
  • refactor: update AppHandle usage to use Arc<AppHandle> for improved memory management (#4491)
    * refactor: update AppHandle usage to use Arc<AppHandle> for improved memory management
    
    * fix: clippy ci
    
    * fix: ensure default_latency_test is safely accessed with non-null assertion
  • fix: clippy errors with new config (#4428)
    * refactor: improve code quality with clippy fixes and standardized logging
    
    - Replace dangerous unwrap()/expect() calls with proper error handling
    - Standardize logging from log:: to logging\! macro with Type:: classifications
    - Fix app handle panics with graceful fallback patterns
    - Improve error resilience across 35+ modules without breaking functionality
    - Reduce clippy warnings from 300+ to 0 in main library code
    
    * chore: update Cargo.toml configuration
    
    * refactor: resolve all clippy warnings
    - Fix Arc clone warnings using explicit Arc::clone syntax across 9 files
    - Add #[allow(clippy::expect_used)] to test functions for appropriate expect usage
    - Remove no-effect statements from debug code cleanup
    - Apply clippy auto-fixes for dbg\! macro removals and path statements
    - Achieve zero clippy warnings on all targets with -D warnings flag
    
    * chore: update Cargo.toml clippy configuration
    
    * refactor: simplify macOS job configuration and improve caching
    
    * refactor: remove unnecessary async/await from service and proxy functions
    
    * refactor: streamline pnpm installation in CI configuration
    
    * refactor: simplify error handling and remove unnecessary else statements
    
    * refactor: replace async/await with synchronous locks for core management
    
    * refactor: add workflow_dispatch trigger to clippy job
    
    * refactor: convert async functions to synchronous for service management
    
    * refactor: convert async functions to synchronous for UWP tool invocation
    
    * fix: change wrong logging
    
    * refactor: convert proxy restoration functions to async
    
    * Revert "refactor: convert proxy restoration functions to async"
    
    This reverts commit b82f5d250b.
    
    * refactor: update proxy restoration functions to return Result types
    
    * fix: handle errors during proxy restoration and update async function signatures
    
    * fix: handle errors during proxy restoration and update async function signatures
    
    * refactor: update restore_pac_proxy and restore_sys_proxy functions to async
    
    * fix: convert restore_pac_proxy and restore_sys_proxy functions to async
    
    * fix: await restore_sys_proxy calls in proxy restoration logic
    
    * fix: suppress clippy warnings for unused async functions in proxy restoration
    
    * fix: suppress clippy warnings for unused async functions in proxy restoration