clash-proxy

refactor: replace unwrap_or with unwrap_or_else for improved error handling (#5163 )

In Rust, the `or` and `or_else` methods have distinct behavioral differences. The `or` method always eagerly evaluates its argument and executes any associated function calls. This can lead to unnecessary performance costs—especially in expensive operations like string processing or file handling—and may even trigger unintended side effects.

In contrast, `or_else` evaluates its closure lazily, only when necessary. Introducing a Clippy lint to disallow `or` sacrifices a bit of code simplicity but ensures predictable behavior and enforces lazy evaluation for better performance.

Tunglies · 2025-10-22 17:33:55 +08:00

2d2167e048

perf: utilize smartstring for string handling (#5149 )

* perf: utilize smartstring for string handling

- Updated various modules to replace standard String with smartstring::alias::String for improved performance and memory efficiency.
- Adjusted string manipulations and conversions throughout the codebase to ensure compatibility with the new smartstring type.
- Enhanced readability and maintainability by using `.into()` for conversions where applicable.
- Ensured that all instances of string handling in configuration, logging, and network management leverage the benefits of smartstring.

* fix: replace wrap_err with stringify_err for better error handling in UWP tool invocation

* refactor: update import path for StringifyErr and adjust string handling in sysopt

* fix: correct import path for CmdResult in UWP module

* fix: update argument type for execute_sysproxy_command to use std::string::String

* fix: add missing CmdResult import in UWP platform module

* fix: improve string handling and error messaging across multiple files

* style: format code for improved readability and consistency across multiple files

* fix: remove unused file

Tunglies · 2025-10-22 16:25:44 +08:00

a05ea64bcd

fix: simplify conditional checks and improve async handler usage across multiple files (#5156 )

* fix: simplify conditional checks and improve async handler usage across multiple files

* fix: add missing AsyncHandler import in find_processes_by_name function

* fix: remove redundant AsyncHandler import in find_processes_by_name function

Tunglies · 2025-10-21 22:39:32 +08:00

afb049ca17

refactor: enhance error handling and logging in core components and server initialization

xmk23333 · 2025-10-20 16:34:38 +08:00

b9dd62e2e6

refactor: improve error handling in AppDataProvider and enhance configuration update logic in CoreManager

xmk23333 · 2025-10-20 13:26:24 +08:00

786c981fe0

Refactor string handling to use into() instead of to_string() for improved performance and consistency across the codebase. This change affects various modules including app.rs, clash.rs, config.rs, core.rs, service.rs, and others, ensuring that string conversions are streamlined and more idiomatic.

Tunglies · 2025-10-14 09:26:20 +08:00

924e7d1022

feat: support for reopen app via desktop shortcuts (#5037 )

* fix: singleton check

* docs: update UPDATELOG.md

---------

Co-authored-by: Slinetrac <realakayuki@gmail.com>

oomeow · 2025-10-12 22:55:40 +08:00

b91087e175

Refactor logging macros to remove print control parameter

- Updated logging macros to eliminate the boolean parameter for print control, simplifying the logging calls throughout the codebase.
- Adjusted all logging calls in various modules (lib.rs, lightweight.rs, help.rs, init.rs, logging.rs, resolve/mod.rs, resolve/scheme.rs, resolve/ui.rs, resolve/window.rs, server.rs, singleton.rs, window_manager.rs) to reflect the new macro structure.
- Ensured consistent logging behavior across the application by standardizing the logging format.

Tunglies · 2025-10-10 13:05:37 +08:00

8c0af66ca9

fix: restart app failed (#4974 )

* fix: failed to restart app

* chore: cleanup

* chore: cargo fmt

* chore: use AsyncHandler

* chore: clippy

* chore: update

oomeow · 2025-10-09 20:08:25 +08:00

1357913f8b

edition 2024 (#4702 )

* feat: update Cargo.toml for 2024 edition and optimize release profiles

* feat: refactor environment variable settings for Linux and improve code organization

* Refactor conditional statements to use `&&` for improved readability

- Updated multiple files to combine nested `if let` statements using `&&` for better clarity and conciseness.
- This change enhances the readability of the code by reducing indentation levels and making the conditions more straightforward.
- Affected files include: media_unlock_checker.rs, profile.rs, clash.rs, profiles.rs, async_proxy_query.rs, core.rs, handle.rs, hotkey.rs, service.rs, timer.rs, tray/mod.rs, merge.rs, seq.rs, config.rs, proxy.rs, window.rs, general.rs, dirs.rs, i18n.rs, init.rs, network.rs, and window.rs in the resolve module.

* refactor: streamline conditional checks using `&&` for improved readability

* fix: update release profile settings for panic behavior and optimization

* fix: adjust optimization level in Cargo.toml and reorder imports in lightweight.rs

Tunglies · 2025-09-10 09:49:06 +08:00

251678493c

Revert "feat: update Cargo.toml for 2024 edition and optimize release profiles (#4681 )"

This reverts commit 31e3104c7f.

Tunglies · 2025-09-08 21:48:09 +08:00

55b95a1985

feat: update Cargo.toml for 2024 edition and optimize release profiles (#4681 )

* feat: update Cargo.toml for 2024 edition and optimize release profiles

* feat: refactor environment variable settings for Linux and improve code organization

* Refactor conditional statements to use `&&` for improved readability

- Updated multiple files to combine nested `if let` statements using `&&` for better clarity and conciseness.
- This change enhances the readability of the code by reducing indentation levels and making the conditions more straightforward.
- Affected files include: media_unlock_checker.rs, profile.rs, clash.rs, profiles.rs, async_proxy_query.rs, core.rs, handle.rs, hotkey.rs, service.rs, timer.rs, tray/mod.rs, merge.rs, seq.rs, config.rs, proxy.rs, window.rs, general.rs, dirs.rs, i18n.rs, init.rs, network.rs, and window.rs in the resolve module.

* refactor: streamline conditional checks using `&&` for improved readability

Tunglies · 2025-09-08 13:57:32 +08:00

31e3104c7f

fix: optimize async handler usage in singleton checks and resource initialization #4576 , #4590 , #4609

Tunglies · 2025-09-02 13:37:14 +08:00

d2b38a8a3c

refactor: streamline resolve_scheme function calls and visibility in utils

Tunglies · 2025-08-30 17:22:52 +08:00

3a7be3dfb7

refactor: enhance async initialization and streamline setup process (#4560 )

* feat: Implement DNS management for macOS

- Added `set_public_dns` and `restore_public_dns` functions in `dns.rs` to manage system DNS settings.
- Introduced `resolve` module to encapsulate DNS and scheme resolution functionalities.
- Implemented `resolve_scheme` function in `scheme.rs` to handle deep links and profile imports.
- Created UI readiness management in `ui.rs` to track and update UI loading states.
- Developed window management logic in `window.rs` to handle window creation and visibility.
- Added initial loading overlay script in `window_script.rs` for better user experience during startup.
- Updated server handling in `server.rs` to integrate new resolve functionalities.
- Refactored window creation calls in `window_manager.rs` to use the new window management logic.

* refactor: streamline asynchronous handling in config and resolve setup

* Revert "refactor: streamline asynchronous handling in config and resolve setup"

This reverts commit 23d7dc86d5.

* fix: optimize asynchronous memory handling

* fix: enhance task logging by adding size check for special cases

* refactor: enhance async initialization and streamline setup process

* refactor: optimize async setup by consolidating initialization tasks

* chore: update changelog for Mihomo(Meta) kernel upgrade to v1.19.13

* fix: improve startup phase initialization performance

* refactor: optimize file read/write performance to reduce application wait time

* refactor: simplify app instance exit logic and adjust system proxy guard initialization

* refactor: change resolve_setup_async to synchronous execution for improved performance

* refactor: update resolve_setup_async to accept AppHandle for improved initialization flow

* refactor: remove unnecessary initialization of portable flag in run function

* refactor: consolidate async initialization tasks into a single blocking call for improved execution flow

* refactor: optimize resolve_setup_async by restructuring async tasks for improved concurrency

* refactor: streamline resolve_setup_async and embed_server for improved async handling

* refactor: separate synchronous and asynchronous setup functions for improved clarity

* refactor: simplify async notification handling and remove redundant network manager initialization

* refactor: enhance async handling in proxy request cache and window creation logic

* refactor: improve code formatting and readability in ProxyRequestCache

* refactor: adjust singleton check timeout and optimize trace size conditions

* refactor: update TRACE_SPECIAL_SIZE to include additional size condition

* refactor: update kode-bridge dependency to version 0.2.1-rc2

* refactor: replace RwLock with AtomicBool for UI readiness and implement event-driven monitoring

* refactor: convert async functions to synchronous for window management

* Update src-tauri/src/utils/resolve/window.rs

* fix: handle missing app_handle in create_window function

* Update src-tauri/src/module/lightweight.rs

Tunglies · 2025-08-29 23:57:42 +08:00

c6a6ea48dd

refactor(async): migrate from sync-blocking async execution to true async with unified AsyncHandler::spawn (#4502 )

* feat: replace all tokio::spawn with unified AsyncHandler::spawn

- 🚀 Core Improvements:
  * Replace all tokio::spawn calls with AsyncHandler::spawn for unified Tauri async task management
  * Prioritize converting sync functions to async functions to reduce spawn usage
  * Use .await directly in async contexts instead of spawn

- 🔧 Major Changes:
  * core/hotkey.rs: Use AsyncHandler::spawn for hotkey callback functions
  * module/lightweight.rs: Async lightweight mode switching
  * feat/window.rs: Convert window operation functions to async, use .await internally
  * feat/proxy.rs, feat/clash.rs: Async proxy and mode switching functions
  * lib.rs: Window focus handling with AsyncHandler::spawn
  * core/tray/mod.rs: Complete async tray event handling

- ✨ Technical Advantages:
  * Unified task tracking and debugging capabilities (via tokio-trace feature)
  * Better error handling and task management
  * Consistency with Tauri runtime
  * Reduced async boundaries for better performance

- 🧪 Verification:
  * Compilation successful with 0 errors, 0 warnings
  * Maintains complete original functionality
  * Optimized async execution flow

* feat: complete tokio fs migration and replace tokio::spawn with AsyncHandler

🚀 Major achievements:
- Migrate 8 core modules from std::fs to tokio::fs
- Create 6 Send-safe wrapper functions using spawn_blocking pattern
- Replace all tokio::spawn calls with AsyncHandler::spawn for unified async task management
- Solve all 19 Send trait compilation errors through innovative spawn_blocking architecture

🔧 Core changes:
- config/profiles.rs: Add profiles_*_safe functions to handle Send trait constraints
- cmd/profile.rs: Update all Tauri commands to use Send-safe operations
- config/prfitem.rs: Replace append_item calls with profiles_append_item_safe
- utils/help.rs: Convert YAML operations to async (read_yaml, save_yaml)
- Multiple modules: Replace tokio::task::spawn_blocking with AsyncHandler::spawn_blocking

✅ Technical innovations:
- spawn_blocking wrapper pattern resolves parking_lot RwLock Send trait conflicts
- Maintain parking_lot performance while achieving Tauri async command compatibility
- Preserve backwards compatibility with gradual migration strategy

🎯 Results:
- Zero compilation errors
- Zero warnings
- All async file operations working correctly
- Complete Send trait compliance for Tauri commands

* feat: refactor app handle and command functions to use async/await for improved performance

* feat: update async handling in profiles and logging functions for improved error handling and performance

* fix: update TRACE_MINI_SIZE constant to improve task logging threshold

* fix(windows): convert service management functions to async for improved performance

* fix: convert service management functions to async for improved responsiveness

* fix(ubuntu): convert install and reinstall service functions to async for improved performance

* fix(linux): convert uninstall_service function to async for improved performance

* fix: convert uninstall_service call to async for improved performance

* fix: convert file and directory creation calls to async for improved performance

* fix: convert hotkey functions to async for improved responsiveness

* chore: update UPDATELOG.md for v2.4.1 with major improvements and performance optimizations

Tunglies · 2025-08-26 01:49:51 +08:00

355a18e5eb

fix: clippy errors with new config (#4428 )

* refactor: improve code quality with clippy fixes and standardized logging

- Replace dangerous unwrap()/expect() calls with proper error handling
- Standardize logging from log:: to logging\! macro with Type:: classifications
- Fix app handle panics with graceful fallback patterns
- Improve error resilience across 35+ modules without breaking functionality
- Reduce clippy warnings from 300+ to 0 in main library code

* chore: update Cargo.toml configuration

* refactor: resolve all clippy warnings
- Fix Arc clone warnings using explicit Arc::clone syntax across 9 files
- Add #[allow(clippy::expect_used)] to test functions for appropriate expect usage
- Remove no-effect statements from debug code cleanup
- Apply clippy auto-fixes for dbg\! macro removals and path statements
- Achieve zero clippy warnings on all targets with -D warnings flag

* chore: update Cargo.toml clippy configuration

* refactor: simplify macOS job configuration and improve caching

* refactor: remove unnecessary async/await from service and proxy functions

* refactor: streamline pnpm installation in CI configuration

* refactor: simplify error handling and remove unnecessary else statements

* refactor: replace async/await with synchronous locks for core management

* refactor: add workflow_dispatch trigger to clippy job

* refactor: convert async functions to synchronous for service management

* refactor: convert async functions to synchronous for UWP tool invocation

* fix: change wrong logging

* refactor: convert proxy restoration functions to async

* Revert "refactor: convert proxy restoration functions to async"

This reverts commit b82f5d250b.

* refactor: update proxy restoration functions to return Result types

* fix: handle errors during proxy restoration and update async function signatures

* fix: handle errors during proxy restoration and update async function signatures

* refactor: update restore_pac_proxy and restore_sys_proxy functions to async

* fix: convert restore_pac_proxy and restore_sys_proxy functions to async

* fix: await restore_sys_proxy calls in proxy restoration logic

* fix: suppress clippy warnings for unused async functions in proxy restoration

* fix: suppress clippy warnings for unused async functions in proxy restoration

Tunglies · 2025-08-18 02:02:25 +08:00

537d27d10b

chore(deps): update cargo dependencies (#4329 )

* chore(deps): update cargo dependencies

* fix: update warp dependency to include server feature

* fix: update return type of scheme_handler to String for consistency

* fix: add hyper-util dependency and update warp path handlers for response status

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Tunglies <tunglies.dev@outlook.com>
Co-authored-by: Tunglies <77394545+Tunglies@users.noreply.github.com>

renovate[bot] · 2025-08-06 22:46:46 +08:00

cdc1fd2d87

refactor(Draft): Replace latest() with latest_ref() and data() with data_mut() in multiple files for improved mutability handling and consistency across the codebase (#3987 )

* feat: add benchmarking for draft operations and new draft management structure

* Refactor Config Access: Replace `latest()` with `latest_ref()` and `data()` with `data_mut()` in multiple files for improved mutability handling and consistency across the codebase.

* refactor: remove DraftNew implementation and related benchmarks for cleaner codebase

Tunglies · 2025-07-04 22:43:23 +08:00

764ef48fd1

Refactor logging statements to use the new formatting syntax for improved readability and consistency across the codebase. This includes updating error, warning, and info logs in various modules such as system commands, configuration, core functionalities, and utilities. Additionally, minor adjustments were made to string formatting in backup and proxy features to enhance clarity.

Tunglies · 2025-06-27 23:30:59 +08:00

a574ced428

Add AsyncHandler for wrapping task spawning

Tunglies · 2025-04-11 17:30:30 +08:00

b6a6f5f434

Fix and Optimize

fix: #3187 and #3096, silent startup can not trigger lightweight mode
fix: optimize startup initializing processing

Tunglies · 2025-04-05 10:28:27 +08:00

0de304d4e3

refactor(logging): replace log_err! with structured logging_error! calls

refactor(cm-service): better error handling from Backend to Frontend

Tunglies · 2025-03-28 03:39:34 +08:00

e8e16f7d57

chore: git hooks for linter and formatter

Tunglies · 2025-03-13 12:51:20 +08:00

b57c6e408a

refactor: unify and simplify the call of app_handle

huzibaca · 2024-09-23 16:31:58 +08:00

1c894f3cfa

chore: update

huzibaca · 2024-09-16 06:37:39 +08:00

7dad46adb4

chore: delete useless emebd server api

huzibaca · 2024-09-12 19:01:08 +08:00

fd963a8e66

chore: update

huzibaca · 2024-09-04 07:53:16 +08:00

c07165531a

chore: update

huzibaca · 2024-09-02 19:33:17 +08:00

6cc81fe6b8

refactor: Associate Profile with Merge/Script.

MystiPanda · 2024-06-29 23:07:44 +08:00

3efef52398

refactor: use async instead of block_on

MystiPanda · 2024-06-29 19:02:37 +08:00

b85929772e

chore: update & fmt & clippy

MystiPanda · 2024-06-12 10:00:22 +08:00

c698b24e01

fix: start param error

MystiPanda · 2024-06-09 20:00:17 +08:00

8c2a4e627e

chore: add content type

MystiPanda · 2024-05-26 19:26:57 +08:00

65924e9a5d

feat: Support PAC Mode

MystiPanda · 2024-05-26 17:59:39 +08:00

b9ec94d835

feat: Support URL Scheme for Windows

#165

MystiPanda · 2024-01-09 21:57:06 +08:00

965f10698b

fix: adjust singleton detect

GyDi · 2022-11-18 08:24:27 +08:00

a786023160

refactor: wip

GyDi · 2022-11-17 17:07:13 +08:00

84c12dee80

refactor: wip

GyDi · 2022-11-14 01:26:33 +08:00

837422fbb8

chore: format rust code

GyDi · 2022-11-12 11:37:23 +08:00

a45c61f19e

fix: init config error

GyDi · 2022-10-28 01:02:47 +08:00

1eecf26429

feat: change default singleton port and support to change the port

GyDi · 2022-09-06 00:45:01 +08:00

72dcdf4483

chore: add dev feature

GyDi · 2022-03-18 10:59:35 +08:00

0fab0f207c

feat: Window Send and Sync

GyDi · 2022-01-04 21:29:04 +08:00

c29eadd9ee

feat: compatible with macos(wip)

GyDi · 2021-12-29 18:49:38 +08:00

1d87f78088

feat: implement a simple singleton process

GyDi · 2021-12-23 01:35:17 +08:00

34725b517b

46 Commits